Add a planetary_variable_source subscription helper #976
Conversation
|
@cpaulik @guyon-planet while I work on #933, would you be willing to see if this is what you're looking for in a PV source helper? |
kevinlacaille
left a comment
kevinlacaille
left a comment
There was a problem hiding this comment.
A few small suggestions and 1 must-fix typo in the example code. Otherwise, looks good to me!
Co-authored-by: Kevin Lacaille <[email protected]>
|
|
||
|
|
||
| def planetary_variable_source( | ||
| var_type: Literal["biomass_proxy", |
There was a problem hiding this comment.
Just wanted to point out that internally we are already using more sources for upcoming forest products.
I'm not sure if there is a way to not duplicate these lists.
There was a problem hiding this comment.
@cpaulik I'm going off what we have at https://developers.planet.com/docs/subscriptions/pvs-subs/#planetary-variables-types-and-ids. Do you know if we publish a machine-readable version of this table for customers?
I'm using the Literal type hints here so that developers get value hints from their IDEs. The SDK does not at this time validate the values at runtime. Thus you can use any values you want, including unavailable PV types and ids. See for example https://github.com/planetlabs/planet-client-python/pull/982/files#diff-661d60b3722e519e66594c89a655b8aa191b919ac27c98ecffde58f984ab120eR355.
There was a problem hiding this comment.
You sparked my curiosity. Since our API docs spell them out I did some digging and found that https://api.planet.com/subscriptions/v1/spec includes the sources types under schemas.PVSourceTypes
|
Quickly tested it, looks great, thanks! |
Resolves #966. API doc improvements for
catalog_source()are included in this PR.